You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request resolves an issue where the site check for Lush Stories was producing false positives for non-existent usernames.
Problem:
The site redirects both valid and invalid profile URLs to a login page for unauthenticated users. This made it impossible for Sherlock to distinguish between a found and not-found profile, causing any username check to be reported as a success.
Solution:
After attempting several detection methods (status_code, response_url), it was determined that a reliable check is not possible without being logged in.
To improve the overall accuracy of the tool and prevent future false positives, this commit completely removes the Lush Stories site from data.json.
This fixes the issue reported by the user in the initial problem description.
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences).
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shreyasNaik0101
force-pushed
the
fix/lush-stories-false-positive
branch
from
This pull request resolves an issue where the site check for Lush Stories was producing false positives for non-existent usernames.
Problem:
The site redirects both valid and invalid profile URLs to a login page for unauthenticated users. This made it impossible for Sherlock to distinguish between a found and not-found profile, causing any username check to be reported as a success.
Solution:
After attempting several detection methods (
status_code,response_url), it was determined that a reliable check is not possible without being logged in.To improve the overall accuracy of the tool and prevent future false positives, this commit completely removes the Lush Stories site from
data.json.This fixes the issue reported by the user in the initial problem description.